Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH]Add Image Processing Folder, include shrinking functions which is content-aware image processing. #487

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

FrancieNagiki
Copy link
Contributor

Description

Add Image Processing Folder, include shrinking functions which is content-aware image processing. Including test cases and examples.

Type of Change

  • New feature (non-breaking change which adds functionality)

Checklist

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

…tent-aware image processing. Including test cases and draft examples
@codecov-commenter
Copy link

codecov-commenter commented Apr 28, 2022

Codecov Report

Merging #487 (b294bd1) into master (7a9da85) will increase coverage by 0.22%.
The diff coverage is 93.91%.

❗ Current head b294bd1 differs from pull request most recent head 5470477. Consider uploading reports for the commit 5470477 to get more accurate results

@@            Coverage Diff             @@
##           master     #487      +/-   ##
==========================================
+ Coverage   93.83%   94.05%   +0.22%     
==========================================
  Files          90       99       +9     
  Lines        7782     9073    +1291     
==========================================
+ Hits         7302     8534    +1232     
- Misses        480      539      +59     
Flag Coverage Δ
unittests 94.05% <93.91%> (+0.22%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pulse2percept/datasets/nanduri2012.py 86.20% <ø> (ø)
pulse2percept/model_selection/optimizers.py 85.71% <0.00%> (+0.57%) ⬆️
pulse2percept/models/setup.py 0.00% <0.00%> (ø)
pulse2percept/processing/setup.py 0.00% <0.00%> (ø)
pulse2percept/setup.py 0.00% <0.00%> (ø)
pulse2percept/stimuli/__init__.py 100.00% <ø> (ø)
pulse2percept/datasets/beyeler2019.py 22.97% <50.00%> (ø)
pulse2percept/utils/parallel.py 87.50% <61.53%> (-6.84%) ⬇️
pulse2percept/models/base.py 87.32% <80.00%> (-0.04%) ⬇️
pulse2percept/utils/optimize.py 92.59% <80.00%> (ø)
... and 62 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9267655...5470477. Read the comment docs.

@FrancieNagiki FrancieNagiki marked this pull request as ready for review April 28, 2022 08:13
Copy link
Member

@mbeyeler mbeyeler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO MB:

  • Fix naming, refactor, simplify
  • Fix edge cases
  • Speed up Cython
  • Add comments & ref
  • Update example

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants