Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RF: Standardise functions between QT and WX dialog backends by getting both from a base class #6335

Open
wants to merge 14 commits into
base: dev
Choose a base branch
from

Conversation

TEParsons
Copy link
Contributor

This has the following advantages:

  • Changing the behaviour of the Dlg class is now much easier for things like parsing syntax, where the backend doesn't matter, as you only have to change it in one place
  • Reduces the danger of multiple backends slipping out of parity (as they already had a bit)
  • If we wanted to add another backend (e.g. tkinter or any new lightweight GUI packages we come across) it's easy to get it up to the level qt and wx are at as most of the API is already written

Copy link

codecov bot commented Mar 25, 2024

Codecov Report

Merging #6335 (441ca09) into dev (4d8528c) will increase coverage by 0.18%.
Report is 16 commits behind head on dev.
The diff coverage is 61.98%.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #6335      +/-   ##
==========================================
+ Coverage   51.86%   52.05%   +0.18%     
==========================================
  Files         335      336       +1     
  Lines       61727    61661      -66     
==========================================
+ Hits        32015    32097      +82     
+ Misses      29712    29564     -148     
Components Coverage Δ
app ∅ <ø> (∅)
boilerplate ∅ <ø> (∅)
library ∅ <ø> (∅)
vm-safe library ∅ <ø> (∅)

@TEParsons TEParsons marked this pull request as ready for review March 25, 2024 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant