Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RF: Supply end message from Builder rather than relying on JS default #6258

Draft
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

TEParsons
Copy link
Contributor

In draft as this needs the accompanying change in PsychoJS (otherwise the end message becomes "Thank you for your patience." twice)

Copy link

codecov bot commented Feb 21, 2024

Codecov Report

Merging #6258 (950be89) into dev (b742eb1) will increase coverage by 0.00%.
Report is 5 commits behind head on dev.
The diff coverage is 100.00%.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev    #6258   +/-   ##
=======================================
  Coverage   51.79%   51.79%           
=======================================
  Files         334      334           
  Lines       61665    61666    +1     
=======================================
+ Hits        31940    31941    +1     
  Misses      29725    29725           
Components Coverage Δ
app ∅ <ø> (∅)
boilerplate ∅ <ø> (∅)
library ∅ <ø> (∅)
vm-safe library ∅ <ø> (∅)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant