Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EN: Improved movie playback support using ffpyplayer #5914

Draft
wants to merge 7 commits into
base: dev
Choose a base branch
from

Conversation

mdcutone
Copy link
Member

This PR adds the MovieFileReader class which will be used to replace the existing ffpyplayer backend used by MovieStim for playback. The new interface can also support other libraries in the future, providing a common interface for other backends, much like we did with MovieFileWriter.

Copy link

codecov bot commented Mar 11, 2024

Codecov Report

Merging #5914 (c9e7615) into dev (45b9fd3) will increase coverage by 31.01%.
Report is 6 commits behind head on dev.
The diff coverage is 20.96%.

❗ Current head c9e7615 differs from pull request most recent head 95550b0. Consider uploading reports for the commit 95550b0 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##              dev    #5914       +/-   ##
===========================================
+ Coverage   20.73%   51.75%   +31.01%     
===========================================
  Files         333      335        +2     
  Lines       60235    61961     +1726     
===========================================
+ Hits        12492    32067    +19575     
+ Misses      47743    29894    -17849     
Components Coverage Δ
app ∅ <ø> (∅)
boilerplate ∅ <ø> (∅)
library ∅ <ø> (∅)
vm-safe library ∅ <ø> (∅)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant