Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Enhancements for gltools #3566

Draft
wants to merge 27 commits into
base: dev
Choose a base branch
from
Draft

Conversation

mdcutone
Copy link
Member

@mdcutone mdcutone commented Feb 13, 2021

WIP PR for gltools which add loads of features, bug fixes, and comprehensive tests. This module will be seeing a lot more use in the future, so we better test it out.

  • Split gltools into separate files for readability.
  • Added pixelUpload function to update texture data without creating a new storage buffer.
  • New functions for procedural mesh generation for rings, cylinders, discs, etc.
  • New mesh clean-up and modelling functions like smoothCreases and mergeVertices.
  • Much faster surface normal calculation.
  • New classes for Frame, Vertex, Render and Texture buffers.
  • Better garbage collection and resource management to keep VRAM use in check.
  • Minor fixes to keep up with Pyglet API changes.
  • Two lens distortion functions for creating distortion meshes for textures, useful for HMDs and other displays which use magnifying lenses.
  • Added comprehensive tests for various parts of gltools.

@lgtm-com
Copy link

lgtm-com bot commented Feb 13, 2021

This pull request introduces 1 alert when merging e7c75a4 into 44478b8 - view on LGTM.com

new alerts:

  • 1 for Nested loops with same variable

@mdcutone mdcutone changed the title WIP: Enhancments for gltools WIP: Enhancements for gltools Feb 13, 2021
@codecov
Copy link

codecov bot commented Feb 14, 2021

Codecov Report

Merging #3566 (3bb2f67) into dev (44478b8) will increase coverage by 0.73%.
The diff coverage is 36.86%.

❗ Current head 3bb2f67 differs from pull request most recent head 21d5860. Consider uploading reports for the commit 21d5860 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##              dev    #3566      +/-   ##
==========================================
+ Coverage   43.14%   43.88%   +0.73%     
==========================================
  Files         267      286      +19     
  Lines       52515    54278    +1763     
  Branches     9032     9282     +250     
==========================================
+ Hits        22659    23820    +1161     
- Misses      27557    28049     +492     
- Partials     2299     2409     +110     
Impacted Files Coverage Δ
psychopy/tools/gltools/_mesh.py 8.16% <8.16%> (ø)
psychopy/tools/gltools/_shader.py 25.38% <25.38%> (ø)
psychopy/tools/gltools/_light.py 25.64% <25.64%> (ø)
psychopy/tools/gltools/_misc.py 36.95% <36.95%> (ø)
psychopy/tools/gltools/_query.py 39.02% <39.02%> (ø)
psychopy/tools/gltools/_material.py 39.50% <39.50%> (ø)
psychopy/tools/gltools/_texture.py 46.12% <46.12%> (ø)
psychopy/tools/gltools/_vertexbuffer.py 48.17% <48.17%> (ø)
psychopy/tools/gltools/_framebuffer.py 64.85% <64.85%> (ø)
psychopy/tools/gltools/_glenv.py 65.62% <65.62%> (ø)
... and 86 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 44478b8...21d5860. Read the comment docs.

@coveralls
Copy link

coveralls commented Feb 14, 2021

Coverage Status

Coverage increased (+0.7%) to 47.685% when pulling 3bb2f67 on mdcutone:gltools-enh into 44478b8 on psychopy:dev.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.4%) to 47.371% when pulling 6e925ad on mdcutone:gltools-enh into 44478b8 on psychopy:dev.

@mdcutone mdcutone marked this pull request as draft February 24, 2021 18:26
@lgtm-com
Copy link

lgtm-com bot commented Apr 1, 2021

This pull request introduces 3 alerts when merging 21d5860 into c0cce66 - view on LGTM.com

new alerts:

  • 2 for Wrong number of arguments in a call
  • 1 for Unused import

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants