-
Notifications
You must be signed in to change notification settings - Fork 434
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
QCManyBody in DDD #3160
Open
loriab
wants to merge
16
commits into
psi4:master
Choose a base branch
from
loriab:qcmb_in_psi
base: master
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
QCManyBody in DDD #3160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
loriab
added
bug
schema
deploys or develops MolSSI/QCSchema
external-interface
For issues about interfaces with external programs: ADCC, CheMPS2, GDMA, MRCC...
driver
For issues that are specifically about Psi's driver.
labels
May 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug
driver
For issues that are specifically about Psi's driver.
external-interface
For issues about interfaces with external programs: ADCC, CheMPS2, GDMA, MRCC...
schema
deploys or develops MolSSI/QCSchema
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a snapshot in which all n-body tests pass using QCManyBody locally. There's lots of code to be erased and reworked yet. And qcmb isn't installed in CI, so tests aren't expected to pass.
User API & Changelog headlines
supersystem_ie_only
that computes the IE rather than MBE, useful for trimers and larger.Dev notes & details
GEOMETRY ITERATIONS
wasn't actually getting set.OPTIMIZATION ITERATIONS
is actually listed in the docs glossary, so switched to that and set it.resp
to the codedeps now that it's on c-f, and thus to the ecosystem testingqcmanybody
, available from c-f or pypibsse_type=cp
+return_total_data=True
(not default for energy) will now no longer do every species in both supersystem (for cp) and natural (for uncp) basis sets. It will do everything in the supersystem basis (since cp requested) and only monomers in the monomer basis (for rtd=T).driver=g/h
+return_total_data=False
, an unlikely combination, won't just fail with syntax errorbsse_type=vmfc
+driver=g/h +
max_nbody`>2 are now computed correctly. Previously (at least since v1.6), only the two highest-body terms were getting summed into the contribution, so values were wrong for trimers and above (assuming max_nbody=fragment count).bsse_type=vmfc
+ multilevel were running unnecessary calculations, so now more efficientsupersystem_ie_only
skips the mbe analysis and does the IE directly. useful for trimers and larger.Checklist
Status