Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Print final MBIS shell populations and widths #3102

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

kzinovjev
Copy link

Description

For some applications it may be helpful to know the converged populations and widths of all shells in MBIS, so here goes the patch. As for the initial values, the info is only printed when debug>=1

User API & Changelog headlines

N/A

Dev notes & details

  • Print converged MBIS shell populations and widths when debug>=1

Checklist

Status

  • Ready for review
  • Ready for merge

@jthorton
Copy link

Hi @kzinovjev great job adding this.

@loriab It would be great to have these available via the qcengine interface so we could store them in QCArchive when MBIS charges are requested on a calculation, can you adviseif any other changes would be needed to be made to make this possible?

@jthorton
Copy link

Hi @kzinovjev just checking over this again and noticed that the populations and widths might already be printed can you check they match what you are printing?

@kzinovjev
Copy link
Author

Hi @kzinovjev just checking over this again and noticed that the populations and widths might already be printed can you check they match what you are printing?

Hi @jthorton, currently only the atomic charges (so, the sum of populations of all the shells) and the widths of the last shell for each atom are printed. In contrast, with this patch the full result of MBIS density fitting is printed, so populations and widths of all the shells. This is helpful if one wants to split the atomic charges into core/valence shells, as in MEDFF, IPML or EMLE methods.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants