Begone, ERISieve (Actually!) #3009
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davpoolechem
force-pushed
the
dpoole34/erisieve-removal
branch
from
bf7aa63
to
cc9a2f3
Compare
davpoolechem
force-pushed
the
dpoole34/erisieve-removal
branch
from
cc9a2f3
to
2c4b761
Compare
davpoolechem
force-pushed
the
dpoole34/erisieve-removal
branch
2 times, most recently
from
dde50c5
to
d9f144a
Compare
davpoolechem
force-pushed
the
dpoole34/erisieve-removal
branch
from
d9f144a
to
cedf473
Compare
davpoolechem
force-pushed
the
dpoole34/erisieve-removal
branch
from
cedf473
to
13ce4d5
Compare
davpoolechem
force-pushed
the
dpoole34/erisieve-removal
branch
2 times, most recently
from
bb24266
to
d766ca3
Compare
davpoolechem
force-pushed
the
dpoole34/erisieve-removal
branch
from
d766ca3
to
01b7a31
Compare
davpoolechem
force-pushed
the
dpoole34/erisieve-removal
branch
from
01b7a31
to
3adc4ba
Compare
davpoolechem
force-pushed
the
dpoole34/erisieve-removal
branch
from
3adc4ba
to
18eb4a3
Compare
davpoolechem
force-pushed
the
dpoole34/erisieve-removal
branch
from
18eb4a3
to
9401de2
Compare
TiborGY
reviewed
Apr 13, 2024
| * | ||
| */ | ||
|
|
||
| class PSI_API __attribute__((deprecated( |
There was a problem hiding this comment.
Since this PR removes a class marked as PSI_API, I think it should be mentioned in the API changes section of the PR.
There was a problem hiding this comment.
Good point. Done and done!
davpoolechem
force-pushed
the
dpoole34/erisieve-removal
branch
from
9401de2
to
cffe16a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The final removal of the
ERISieveclass, and the culmination of the work in PRs #2935 and #2974. This fully, and completely, gets rid ofERISievefrom Psi4, withTwoBodyAOIntnow being the class of choice for ERI computations.Note: Now that v1.9 has released officially with ERISieve throwing an UpgradeHelper exception, I am opening this up for review.
User API & Changelog headlines
Dev notes & details
ERISieveclass in Psi4, from build files to UpgradeHelper Python functions to C++ implementation details.Questions
N/A
Checklist
Status