-
Notifications
You must be signed in to change notification settings - Fork 600
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed ^A
/^B
and added support for Windows ConPty.
#2209
base: master
Are you sure you want to change the base?
Conversation
412436b
to
f891dfb
Compare
\001
/\002
escape sequences optional.^A
/^B
and added support for Windows ConPty.
…ry.config.escape_headers`.
Fixed unit tests to also work on Windows.
…s on prompts only.
0c00c26
to
6dc1f09
Compare
Fixed escape codes for Windows, when Ansi is available.
Added `Pry.config.escape_prompt` to manage adding those control characters to the prompt (the default is `true`). | ||
It can then be disabled for terminals that don't have readline, or where readline's version doesn't support those characters. | ||
\ | ||
Added support for [ConPty](https://devblogs.microsoft.com/commandline/windows-command-line-introducing-the-windows-pseudo-console-conpty/) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For what it's worth, ConPTY is not the name we use for the version of the console that supports VT/control sequences.
ENABLE_VIRTUAL_TERMINAL_PROCESSING
enables VT sequences on a fairly old version of Windows 10 -- something like "10.0.10240". That's the only thing you'll need to check. 😄
ConPTY is a newer API that lets somebody else display the UI for the console, instead of leaving us to do it. That's how somebody like alacritty or hyper can run pry! It is much newer (Windows 10 version 17763 or higher.)
Fortunately, you only need the first thing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(Happy to answer any questions about it! I'm the engineering lead for the console and Windows Terminal. 👋)
@kyrylo @SilverPhoenix99 This has been open for a month now and it looks good... could we get it merged please? 😄 |
Pretty please? |
Bumping for visibility, it's been another month and I'd like to see this get added. |
Is there a blocker to getting this merged? |
@Ikariusrb I don't think so, it's on my list to properly review this. And to also configure Windows tests to Github Actions to ensure it keeps working. @kyrylo any thoughts over here? |
Fixed issue with printing control characters
\001
/^A
and\002
/^B
.Added
Pry.config.escape_prompt
to manage adding those control characters to the prompt (the default istrue
).It can then be disabled for terminals that don't have readline, or where readline's version doesn't support those characters.
Added support for ConPty in Windows, which supports Ansi escapes natively.
Fixed all unit tests to run in Windows.