feat(aws): Add new kafka service #4001
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
provider/aws
Closed
sergargar
reviewed
May 15, 2024
| "Code": { | ||
| "CLI": "aws kafka update-cluster-configuration --cluster-arn <arn_cluster> --current-version <current_version> --target-version <latest_version>", | ||
| "NativeIaC": "", | ||
| "Other": "", |
There was a problem hiding this comment.
Suggested change
| "Other": "", | |
| "Other": "https://www.trendmicro.com/cloudoneconformity/knowledge-base/aws/MSK/enable-apache-kafka-latest-security-features.html", |
sergargar
reviewed
May 15, 2024
| }, | ||
| "Recommendation": { | ||
| "Text": "Change the database to private mode.", | ||
| "Url": "https://www.trendmicro.com/cloudoneconformity/knowledge-base/aws/MSK/enable-apache-kafka-latest-security-features.html" |
There was a problem hiding this comment.
Suggested change
| "Url": "https://www.trendmicro.com/cloudoneconformity/knowledge-base/aws/MSK/enable-apache-kafka-latest-security-features.html" | |
| "Url": "https://docs.aws.amazon.com/msk/latest/developerguide/version-support.html#version-upgrades" |
sergargar
reviewed
May 15, 2024
|
|
||
| for page in cluster_paginator.paginate(): | ||
| for cluster in page["ClusterInfoList"]: | ||
| self.clusters[cluster.get("ClusterArn", "")] = Cluster( |
There was a problem hiding this comment.
Please use the resource filter:
if not self.audit_resources or (
is_resource_filtered(arn, self.audit_resources)
):
sergargar
reviewed
May 15, 2024
Comment on lines
20
to
22
| if cluster.kafka_version != getattr( | ||
| kafka_client.kafka_versions[-1], "version", "" | ||
| ): |
There was a problem hiding this comment.
getattr is not needed here ;)
puchy22
changed the title
puchy22
changed the title
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4001 +/- ##
=======================================
Coverage 86.51% 86.52%
=======================================
Files 768 771 +3
Lines 23899 23971 +72
=======================================
+ Hits 20677 20741 +64
- Misses 3222 3230 +8 ☔ View full report in Codecov by Sentry. |
sergargar
reviewed
May 16, 2024
| "Terraform": "" | ||
| }, | ||
| "Recommendation": { | ||
| "Text": "Change the database to private mode.", |
sergargar
reviewed
May 16, 2024
sergargar
requested changes
May 16, 2024
Use arn variable Co-authored-by: Sergio Garcia <38561120+sergargar@users.noreply.github.com>
Use arn variable Co-authored-by: Sergio Garcia <38561120+sergargar@users.noreply.github.com>
…a-MSK-Checks' of github.com:puchy22/prowler into PRWLR-2756-OSS-Amazon-Managed-Streaming-for-Apache-Kafka-MSK-Checks
sergargar
reviewed
May 16, 2024
| @@ -0,0 +1,32 @@ | |||
| { | |||
| "Provider": "aws", | |||
| "CheckID": "kafka_cluster_use_latest_version", | |||
There was a problem hiding this comment.
Suggested change
| "CheckID": "kafka_cluster_use_latest_version", | |
| "CheckID": "kafka_cluster_uses_latest_version", |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Add new Kafka service with one basic check.
Description
It adds new service code, basic check code to ensure using the latest version of Kafka and their respective unit tests.
License
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.