chore(acm): Improve check for expired and near-expiration certificates #3967
+104
−34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
provider/aws
|
Hi @MrMoshkovitz we cannot remove neither change the current ACM check name since it'll be a breaking change in Prowler. As I commented in the issue, the better way is to modify the status extended and the severity regarding the check is either close to expiration or expired. Could you please modify the code to do that? Thanks! |
jfagoagas
changed the title
|
Hi @jfagoagas |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request addresses the issue described in Bug Report #3966 . It separates the checks for expired ACM certificates and near-expiration ACM certificates into distinct checks with different severities and metadata.
Changes Made
acm_certificates_near_expiration_check.pyandacm_certificates_expired_check.pyacm_certificates_near_expiration_check.jsonandacm_certificates_expired_check.jsonIssue Link
Bug Report #3966