Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare 5.6.4 release #1203

Merged
merged 8 commits into from
May 25, 2024
Merged

Prepare 5.6.4 release #1203

merged 8 commits into from
May 25, 2024

Conversation

gouttegd
Copy link
Collaborator

This PR

  • updates the OWLAPI to the latest 4.5.29 release;
  • updates the logging libraries (SLF4J and Logback-classic) to their latest releases compatible with Protégé;
  • bumps the version number to 5.6.4.

We update the Logback-classic library to 1.2.13 (latest release of the
1.2.x branch). This requires a simultaenous update of SLF4J, because of
some incompatible changes between Logback 1.1 and 1.2.

Those are the latest versions we can update to, as newer branches 2.x
(for SLF4J) and 1.3.x (for Logback) rely on a completely different
initialisation mechanism that I currently cannot get to work with
Protégé.
@gouttegd gouttegd self-assigned this May 13, 2024
@ykazakov
Copy link
Contributor

Would it be also possible to publish the new version on maven central? The latest published version there is 5.5.0.

@gouttegd
Copy link
Collaborator Author

@ykazakov Not possible for me, unfortunately. I only have privileges to make GitHub releases and updating the download links on Protégé’s website. I cannot push artefacts to Maven Central. :(

@ykazakov
Copy link
Contributor

@matthewhorridge have you been publishing Protege artifacts to Maven Central?

@ykazakov
Copy link
Contributor

I just checked: it looks like @matthewhorridge was signing the artifatcts.

% gpg --search-keys 53C1E4660BFDA444
gpg: data source: https://185.125.188.26:443
(1)	Matthew Horridge <matthew.horridge@stanford.edu>
	  2048 bit RSA key 53C1E4660BFDA444, created: 2014-12-21
Keys 1-1 of 1 for "53C1E4660BFDA444".

@matthewhorridge
Copy link
Contributor

If @gouttegd could add this GitHub workflow, it will publish to central,

name: Publish package to the Maven Central Repository
on:
  release:
    types: [released]

jobs:
  publish:
    runs-on: ubuntu-latest
    steps:
      - uses: actions/checkout@v3
      - name: Set up Maven Central Repository
        uses: actions/setup-java@v3
        with:
          java-version: '17'
          distribution: 'adopt'
          server-id: ossrh
          server-username: OSSRH_USERNAME
          server-password: OSSRH_TOKEN
          gpg-private-key: ${{secrets.GPG_PRIVATE_KEY}}
          gpg-passphrase: GPG_PASSPHRASE
      - name: Publish package
        run: mvn --batch-mode -Prelease deploy
env:
  GPG_PASSPHRASE: ${{secrets.GPG_PASSPHRASE}}
  OSSRH_USERNAME: ${{secrets.OSSRH_USERNAME}}
  OSSRH_TOKEN: ${{secrets.OSSRH_TOKEN}}

@gouttegd
Copy link
Collaborator Author

@matthewhorridge Excellent, will do that in time for the upcoming 5.6.4, thanks!

@matthewhorridge
Copy link
Contributor

Sure!

This one might actually be a bit better. It ensures the version is set to match the GitHub release tag name (assuming a properly formed major.minor.patch tag name here).

name: Publish package to the Maven Central Repository
on:
  release:
    types: [released]

jobs:
  publish:
    runs-on: ubuntu-latest
    steps:
      - uses: actions/checkout@v3
      - name: Set up Maven Central Repository
        uses: actions/setup-java@v3
        with:
          java-version: '17'
          distribution: 'adopt'
          server-id: ossrh
          server-username: OSSRH_USERNAME
          server-password: OSSRH_TOKEN
          gpg-private-key: ${{secrets.GPG_PRIVATE_KEY}}
          gpg-passphrase: GPG_PASSPHRASE
      - if: github.event.release
        name: Update version in pom.xml (Release only)
        run: mvn -B versions:set -DnewVersion=${{ github.event.release.tag_name }} -DgenerateBackupPoms=false
      - name: Publish package
        run: mvn --batch-mode -Prelease deploy
env:
  GPG_PASSPHRASE: ${{secrets.GPG_PASSPHRASE}}
  OSSRH_USERNAME: ${{secrets.OSSRH_USERNAME}}
  OSSRH_TOKEN: ${{secrets.OSSRH_TOKEN}}

@gouttegd
Copy link
Collaborator Author

I just did a test on the branch for the future 5.6.4 release (with a 5.6.4-beta3 version number), and it worked as expected.

All future releases will be published on Maven Central, as they were before the 5.6.x branch.

gouttegd and others added 4 commits May 19, 2024 19:42
Use a freshly built launcher that includes an option to silence a
warning about illegal reflective access on the part of the JGoodies
Common library.
Apply to the shell launcher the same logic as in the new updated
launcher: add a --add-opens option to silence the "illegal reflective
access" warning.
@gouttegd gouttegd merged commit 23df63b into master May 25, 2024
3 checks passed
@gouttegd gouttegd deleted the prepare-5.6.4-release branch May 25, 2024 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants