New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs Improvements for Gitlab CI Integration #460

Merged

ashkulz merged 1 commit into prontolabs:master from TruemarkDev:documentation/gitlab-integration-improvements

Apr 1, 2024

Contributor

coolprobn commented Mar 29, 2024

Current example for Gitlab CI Integration fails in CI due to following two reasons:

cmake is required for rugged but it's not installed yet
Gitlab CI fetches changes with git depth set to 20 by default and can't find the target branch

This PR is intended for improving the documentation so that configurations work as it is when copied to any gitlab-ci.yml

Changes Done:

Install cmake required for rugged
git fetch target branch for the PR
Comments to elaborate some commands
Link Blog "Integrate Pronto with Gitlab CI for Rails App" (Disclaimer, I am the Author)

These new changes can help beginners especially and can minimize issues like #457 and maybe this one too #441


          Docs Improvements for Gitlab CI Integration

1eb61da

coolprobn requested a review from a team as a code owner

March 29, 2024 18:07

ashkulz approved these changes

View reviewed changes

ashkulz merged commit 1346a03 into prontolabs:master

1 check passed

Member

ashkulz commented Apr 1, 2024

Thanks for the contribution, @coolprobn!

coolprobn deleted the documentation/gitlab-integration-improvements branch

April 1, 2024 09:10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment