Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds Ruby 3.2 to the CI matrix #438

Merged
merged 1 commit into from Dec 30, 2022
Merged

Adds Ruby 3.2 to the CI matrix #438

merged 1 commit into from Dec 30, 2022

Conversation

petergoldstein
Copy link
Contributor

Also updates checkout action version.

The current published version of pronto is not compatible with Ruby 3.2, because of the rugged dependency. Rugged only became Ruby 3.2 compliant as of version 1.4.2 or so. If would be great to have this merged and a new gem version published.

Currently this is blocking some compatibility efforts on https://github.com/JEG2/highline , so an updated gem would definitely be appreciated.

cc: @abinoam

@petergoldstein petergoldstein requested a review from a team as a code owner December 30, 2022 03:35
@ashkulz ashkulz merged commit 60cd2cc into prontolabs:master Dec 30, 2022
@ashkulz
Copy link
Member

ashkulz commented Dec 30, 2022

Thanks for the contribution, @petergoldstein! I was kinda waiting for #433 before releasing a new version, but you're right -- it's been a long time since a release 👍

@ashkulz
Copy link
Member

ashkulz commented Dec 30, 2022

I don't have the machine I normally use, will try to release over the weekend.

@petergoldstein
Copy link
Contributor Author

@ashkulz Sounds good. Once that's done I can put up PRs that add Ruby 3.1 and 3.2 to CI for all the assorted pronto gems.

@ashkulz
Copy link
Member

ashkulz commented Dec 31, 2022

Release 0.11.1 has been pushed to RubyGems.

@petergoldstein
Copy link
Contributor Author

@ashkulz Great. I've submitted PRs for everything but pronto-poper and pronto-rubocop. The former still doesn't build because poper has direct dependencies on pre-1.0 rugged. The latter has a few spec failures I need to look at.

@ashkulz
Copy link
Member

ashkulz commented Dec 31, 2022

@petergoldstein thanks for all the PRs, I've merged all of them 🎉

@petergoldstein
Copy link
Contributor Author

@ashkulz Great. Thanks. Not exactly sure why pronto-rubocop is failing - it's failing now across all Rubies, presumably because of a change in rugged. May be worth a look from someone who is more familiar with the gem than I am.

@ashkulz
Copy link
Member

ashkulz commented Dec 31, 2022

@petergoldstein did you update your fork? I fixed a similar-sounding issue in prontolabs/pronto-rubocop@36c6acc 🤔

@petergoldstein
Copy link
Contributor Author

@ashkulz I hadn't caught that update. I'll rebase and see if that resolves the issue. Thanks!

@petergoldstein
Copy link
Contributor Author

@ashkulz Yep, that was it. Submitted pronto-rubocop PR.

I'm not clear if poper is still maintained, as it hasn't received any updates in 3.5 years and has open, critical commits. So I'm not going to worry about pronto-poper

I think that's it for me. Thanks for merging all of these PRs.

@abinoam
Copy link
Contributor

abinoam commented Dec 31, 2022

Dear @mmozuras,

Who has commit and release permission for Poper gem?

If possible, could add more contributors like @petergoldstein and @ashkulz?

@abinoam
Copy link
Contributor

abinoam commented Dec 31, 2022

mmozuras/poper#19

@ashkulz
Copy link
Member

ashkulz commented Dec 31, 2022

@petergoldstein, thanks for working on them -- happy new year in advance!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants