Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: pull_sha return value when no pull request #434

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: pull_sha return value when no pull request #434

wants to merge 1 commit into from
+2 −0

Commits on Sep 29, 2022

  1. fix: pull_sha return value when no pull request 

    Pronto::Github#pull throws error when the PR cannot be found,
thus `pull[:head][:sha] if pull` makes no sense (it exists or throws)

We fix this by catching Pronto::Error (thrown when PR cannot be found in
Pronto::GithubPull#pull_by_id, Pronto::GithubPull#pull_by_branch or
Pronto::GithubPull#pull_by_commit) and return nil.
    @zygzagZ
    zygzagZ committed Sep 29, 2022
    Configuration menu
    Copy the full SHA
    3387a7a View commit details
    Browse the repository at this point in the history