Add configurable Github review_type with 'REQUEST_CHANGES' as default #334
Conversation
|
@gyfis sorry for the delay on getting you feedback. Could you rebase against master so we can get this merged? |
|
@doomspork Thanks for the reminder, I rebased the code against the latest master. |
There was a problem hiding this comment.
Looks solid. I have doubts about REQUEST_CHANGES as a default behavior. As much as personally I'd prefer to use it with REQUEST_CHANGES, I'm afraid some of our users might be annoyed that we're breaking compatibility.
@gyfis @prontolabs/core What do you think?
|
@mknapik That makes sense. Thanks for the review! @doomspork Updated the code to use COMMENT as the default. |
|
@doomspork @mknapik How do you feel about this change? |
|
Looks good @gyfis, thank you for your patience! We're definitely in need of more maintainers if you'd like to be more involved in Pronto's development 😁 |
|
Thanks for the merge @doomspork and for the offer! I'm busy (as we all are), but I'll keep it in mind 👍 |
…prontolabs#334) * Add configurable github review_type with 'request_changes' as default * Use 'COMMENT' as default instead of 'REQUEST_CHANGES'
NOTE: This PR is a replacement for PR #320 which lost its traction.
Issue
#319
Implements
Similarly to #320 this adds
REQUEST_CHANGESas the default event, with some more code around the configurability and specs for that.