feat: range iterator #6711
Open
feat: range iterator #6711
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Restore camera settings according to 100x100
Restore camera settings according to 100x100
Regarding the setCamera() example, the transition was not clean, so I modified the code.
It looks like a parallel projection, so I'll fix it.
The way I set the background was sloppy, so I fixed it.
camera(0, 0, 50*sqrt(3), 0, 0, 0, 0, 1, 0); perspective(PI/3, 1, 5*sqrt(3), 500*sqrt(3));
add information about new 80,800,8000 camera default system.
fix indent
…dd-suhani6904 docs: add suhani6904 as a contributor for translation
The image() function uses push() to pop() internally, so the processing is duplicated and it's not pretty. Also, since it may be affected by imageMode(), I thought this would be better.
add noLights()
…-docs Update WebGL contributor docs
Line 42 example -> examples tutorial -> tutorials etc -> etc.
I forgot to change the name, so I will change the name.
…ra-reference-bug Fixed example broken by processing#6216 and added information for new camera default setting
Typo in contributor_guidelines.md: 'Close' should be 'Clone'. processing#6632
Punctuations and Spellings Fixed
…dd-haarsh157 docs: add haarsh157 as a contributor for code, and bug
…dd-sudhanshuv1 docs: add sudhanshuv1 as a contributor for code
…cs-fix Fixed the shader in the `endShape()` example to make the boxes separated from one another
bugfix processing#6653 vertexNormal() is not defined,replaces with normal
Updated docs for p5.Shader.js
fixed the doubleClicked() in offline docs
…octype add missing return type
Fix minor documentation typo in `src/math/random.js`.
fix documentation typo in src/math/random.js
fixed second example in the reference page for `acos()`
make parms optional
|
🎉 Thanks for opening this pull request! Please check out our contributing guidelines if you haven't already. And be sure to add yourself to the list of contributors on the readme page! |
17 tasks
|
@all-contributors please add @ohayouarmaan |
|
I couldn't determine any contributions to add, did you specify any contributions? |
|
@all-contributors please add @ohayouarmaan for code |
|
I've put up a pull request to add @ohayouarmaan! 🎉 |
|
@ohayouarmaan For p5.js 2.0 we are not currently accepting implementation and just proposals. I will leave this PR around for now but I won't be reviewing it for the time being. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves#6644 : This PR adds a feature of range iterator which can be used to iterate over a certain value
Changes:
I changed the array_functions.js file inside the src/utilities and added the method range which takes in 3 optional arguments start, end, step if only one argument is provided it is assigned to the end and start gets initialized to 0 and step gets initialized to 1, if two arguments are provided then the first one gets assigned to start whereas the second one gets assigned to the end and step by default is 1, And if all three are provided then it gets assigned to start, end, step respectively
npm run lintpasses