feat(schema-files-loader): Customize file loading logic #24085
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size-limit report 📦
|
CodSpeed Performance ReportMerging #24085 will not alter performanceComparing Summary
|
SevInf
added a commit
to prisma/language-tools
that referenced
this pull request
May 8, 2024
Use `@prisma/schema-files-loader` to resolve schema files from memory or disk. See also prisma/prisma#24085 Message handler's methods now accept `PrismaSchema` instance from outside, rather than creating it from a single document. Singatures of the methods are also adjusted to consistently be in `(schema, intitianigDocument, params)` form.
SevInf
force-pushed
the
schema-files-resolver
branch
from
a3e6c2f
to
08128cb
Compare
Druue
approved these changes
May 8, 2024
packages/schema-files-loader/src/resolver/CompositeFilesResolver.ts
Outdated
Show resolved
Hide resolved
This comment was marked as outdated.
This comment was marked as outdated.
|
This seems like something broke here |
|
No dependency changes detected. Learn more about Socket for GitHub ↗︎ 👍 No dependency changes detected in pull request |
SevInf
force-pushed
the
schema-files-resolver
branch
from
81aa269
to
87e3454
Compare
SevInf
added a commit
to prisma/language-tools
that referenced
this pull request
May 14, 2024
Use `@prisma/schema-files-loader` to resolve schema files from memory or disk. See also prisma/prisma#24085 Message handler's methods now accept `PrismaSchema` instance from outside, rather than creating it from a single document. Singatures of the methods are also adjusted to consistently be in `(schema, intitianigDocument, params)` form.
Allows to swap files resolution logic used by the package. By default, package still uses real fs (see `realFsResolver`). Additinal implementatins are: - `InMemoryFilesResolver` as the name suggests, keeps virtual file tree in memory. - `CompsoiteFilesResolver` combines two resolvers together. Both will be used for language-tools, where some of the source files might diverge from their on-disk content while editing. Contribute to prisma/team-orm#1042
SevInf
force-pushed
the
schema-files-resolver
branch
from
87e3454
to
ab7b6cb
Compare
SevInf
added a commit
to prisma/language-tools
that referenced
this pull request
May 14, 2024
Use `@prisma/schema-files-loader` to resolve schema files from memory or disk. See also prisma/prisma#24085 Message handler's methods now accept `PrismaSchema` instance from outside, rather than creating it from a single document. Singatures of the methods are also adjusted to consistently be in `(schema, intitianigDocument, params)` form.
SevInf
added a commit
to prisma/language-tools
that referenced
this pull request
May 15, 2024
Use `@prisma/schema-files-loader` to resolve schema files from memory or disk. See also prisma/prisma#24085 Message handler's methods now accept `PrismaSchema` instance from outside, rather than creating it from a single document. Singatures of the methods are also adjusted to consistently be in `(schema, intitianigDocument, params)` form.
SevInf
added a commit
to prisma/language-tools
that referenced
this pull request
May 15, 2024
Use `@prisma/schema-files-loader` to resolve schema files from memory or disk. See also prisma/prisma#24085 Message handler's methods now accept `PrismaSchema` instance from outside, rather than creating it from a single document. Singatures of the methods are also adjusted to consistently be in `(schema, intitianigDocument, params)` form.
SevInf
added a commit
to prisma/language-tools
that referenced
this pull request
May 15, 2024
Use `@prisma/schema-files-loader` to resolve schema files from memory or disk. See also prisma/prisma#24085 Message handler's methods now accept `PrismaSchema` instance from outside, rather than creating it from a single document. Singatures of the methods are also adjusted to consistently be in `(schema, intitianigDocument, params)` form.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows to swap files resolution logic used by the package.
By default, package still uses real fs (see
realFsResolver).Additinal implementatins are:
InMemoryFilesResolveras the name suggests, keeps virtual file treein memory.
CompsoiteFilesResolvercombines two resolvers together.Both will be used for language-tools, where some of the source files
might diverge from their on-disk content while editing.
We had to make them both aware of potential case-sensitivity and adjust their logic
accordingly, because on case-insensitive file systems URIs we getting from VSCode
will not neccessary match casing of files on disk. Both new resolvers need to be aware of that
so they can de-duplicate in-memory and on-disk entries correctly on each system.
Contribute to prisma/team-orm#1042
For usage, see prisma/language-tools#1718
/integration