battle-anim: fix UB by subtracting by 16 #1839
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current code follows the nonsensical asm generated by agbcc, which converted a subtraction by 16 into an addition by a halfword value of -16. This conversion happened at the portion of the compiler that does platform-specific transformations. This code in C is UB, as it relies on overflowing of a negative value. Signed-off-by:Arven
AreaZeroArven
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current code follows the nonsensical asm
generated by agbcc, which converted a
subtraction by 16 into an addition by
a halfword value of -16.
This conversion happened at the
portion of the compiler
that does platform-specific transformations.
This code in C is UB,
as it relies on overflowing of a negative value.
Signed-off-by:Arven