Implement cache refresh after file changed #22750
Conversation
beinan
force-pushed
the
last_modified_time
branch
from
8526eba
to
a33e020
Compare
| throws IOException | ||
| { | ||
| if (!cachingEnabled) { | ||
| return fileSystem; | ||
| } | ||
|
|
||
| checkState(cacheType != null); | ||
| checkState(cacheConfig.getCacheType() != null); |
There was a problem hiding this comment.
nit: Do you also want to check whether cacheConfig is null or not?
There was a problem hiding this comment.
good catch, just fixed it
|
Re-running the failed test. |
|
@beinan Why don't we do this by default? So, we do not encounter such staleless problems at all. |
beinan
force-pushed
the
last_modified_time
branch
from
a33e020
to
c745af4
Compare
|
@zacw7 do you also want to take a look at this PR? The change is behind a newly added flag which is disabled by default, so I think there should be no impact on Meta's production. |
Good question @nmahadevuni! I make this not enabled by default just because it will invalidate all your data cached which might make the cache hit rate drop to zero. Some of the local cache users such Meta they really have a very high SLA, I just want to give them a chance to change the configuration explicitly once they are ready. |
beinan
force-pushed
the
last_modified_time
branch
from
c745af4
to
08ea0bf
Compare
|
force push to rerun the test |
fix issue #22019