Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP]Presto Lance Connector #22749

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

beinan
Copy link
Member

@beinan beinan commented May 14, 2024

Description

Motivation and Context

Impact

Test Plan

Contributor checklist

  • Please make sure your submission complies with our development, formatting, commit message, and attribution guidelines.
  • PR description addresses the issue accurately and concisely. If the change is non-trivial, a GitHub Issue is referenced.
  • Documented new properties (with its default value), SQL syntax, functions, or other functionality.
  • If release notes are required, they follow the release notes guidelines.
  • Adequate tests were added if applicable.
  • CI passed.

Release Notes

Please follow release notes guidelines and fill in the release notes below.

== RELEASE NOTES ==

General Changes
* Add LanceDB connector :pr:`22749`

@beinan beinan requested a review from a team as a code owner May 14, 2024 23:31
@beinan beinan requested a review from presto-oss May 14, 2024 23:31
@tdcmeehan tdcmeehan self-assigned this May 15, 2024
@steveburnett
Copy link
Contributor

Suggest add PR number to the release note entry, as follows:

== RELEASE NOTES ==

General Changes
* Add LanceDB connector :pr:`22749`

@tdcmeehan
Copy link
Contributor

This might be orthogonal, but does it also make sense to add integration into the Lance file format? I am just thinking of ML pipeline observability/debugging.

@beinan
Copy link
Member Author

beinan commented May 19, 2024

This might be orthogonal, but does it also make sense to add integration into the Lance file format? I am just thinking of ML pipeline observability/debugging.

Good point! I'm thinking integrating Lance's format with Prestissimo could be more natural, considering Lance already provides an arrow-based interface.
This PR might be more focus on metadata and query planning part

@steveburnett
Copy link
Contributor

Understanding this is currently WIP, will documentation be added for this new connector?

@tdcmeehan
Copy link
Contributor

@beinan how will the metadata work? Does it integrate with an existing catalog like HMS, or does it require a custom catalog?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants