Make judgements follow hitcircles and enable them in magnetised, repel and depth

[DavidBeh]

Addresses #20139

Makes judgements appear based on the DrawableHitobjects position instead of the Hitobjects position which is not updated by mods moving single Hitobjects. They move with hitobjects as long as the drawables are alive, so they move with the shadow of hits and stay on misses.

Judgements are enabled for magnetised, repel and depth.

[bdach]

Measured overhead in profiling seems acceptable:

diff --git a/osu.Game.Rulesets.Osu/Objects/Drawables/DrawableOsuJudgement.cs b/osu.Game.Rulesets.Osu/Objects/Drawables/DrawableOsuJudgement.cs
index 98fb99609a..475c2bac72 100644
--- a/osu.Game.Rulesets.Osu/Objects/Drawables/DrawableOsuJudgement.cs
+++ b/osu.Game.Rulesets.Osu/Objects/Drawables/DrawableOsuJudgement.cs
@@ -42,6 +42,11 @@ protected override void Update()
         {
             base.Update();
 
+            theThingThatIWishToProfileRightNow();
+        }
+
+        private void theThingThatIWishToProfileRightNow()
+        {
             if (JudgedObject is DrawableOsuHitObject osuObject && JudgedObject.IsInUse)
             {
                 Position = osuObject.ToSpaceOfOtherDrawable(osuObject.OriginPosition, Parent!);

[peppy]

I'm fine with this on a code level, but depth mod may need some adjustments to ensure the judgements keep moving, if that is the goal:

osu.2024-05-29.at.14.56.34.mp4

A potentially more appropriate path would be to lock the position when judgement happens (based on the DrawableHitObject still, to still fix the main reasons as to why they were disabled), which may feel better.

[peppy]

Might need a bit of thought in terms of game feel

[peppy]

Proposed:

osu.2024-05-29.at.15.06.53.mp4

diff --git a/osu.Game.Rulesets.Osu/Objects/Drawables/DrawableOsuJudgement.cs b/osu.Game.Rulesets.Osu/Objects/Drawables/DrawableOsuJudgement.cs
index 98fb99609a..6e252a53e2 100644
--- a/osu.Game.Rulesets.Osu/Objects/Drawables/DrawableOsuJudgement.cs
+++ b/osu.Game.Rulesets.Osu/Objects/Drawables/DrawableOsuJudgement.cs
@@ -17,6 +17,8 @@ public partial class DrawableOsuJudgement : DrawableJudgement
         [Resolved]
         private OsuConfigManager config { get; set; } = null!;
 
+        private bool positionTransferred;
+
         [BackgroundDependencyLoader]
         private void load()
         {
@@ -36,16 +38,20 @@ protected override void PrepareForUse()
 
             Lighting.ResetAnimation();
             Lighting.SetColourFrom(JudgedObject, Result);
+
+            positionTransferred = false;
         }
 
         protected override void Update()
         {
             base.Update();
 
-            if (JudgedObject is DrawableOsuHitObject osuObject && JudgedObject.IsInUse)
+            if (!positionTransferred && JudgedObject is DrawableOsuHitObject osuObject && JudgedObject.IsInUse)
             {
                 Position = osuObject.ToSpaceOfOtherDrawable(osuObject.OriginPosition, Parent!);
                 Scale = new Vector2(osuObject.HitObject.Scale);
+
+                positionTransferred = true;
             }
         }
 

(there may be a better way to write this)

[DavidBeh]

I am not sure if that looks good with Argon Skins and hit lighting because these also move after the result

[peppy]

Argon for reference:

osu.2024-05-30.at.03.59.16.mp4

I think it looks fine? Also consider that if anything, I'd say we need to move the hit lighting out of the judgement in argon at some point 😅

[bdach]

I agree that the proposal above looks less bad than the original and the patch seems fine so I've applied.