Reset SongSelect dim before applying PlayerLoader dim

[64ArthurAraujo]

Fixes #25515, and as i explained there the issue is that when you disable background blur the game sets a 60% dim for the SongSelect background, when the user enters the PlayerLoader screen it adds +20% dim on top of the song select background causing it to appear darker. The fix was to simply reset the dim Song Select applied to 0 before applying the PlayerLoader dim, the dim is applied again when the user goes back to Song Select.

Before the PR

PlayerLoader	Editor PlayerLoader

After the PR

PlayerLoader	Editor PlayerLoader

[bdach]

Unit tests would be nice

[64ArthurAraujo]

Unit tests would be nice

since it was such a small thing i tought it wouldnt need one. Also im not sure where to add them

[bdach]

Looking at this again, I'm not sure whether this is the correct change to apply and the screenshots in the OP even illustrate that. Yes it makes player loader display consistently, but the issue thread also raises text readability concerns:

I don't think this is valid behavior, some backgrounds are too bright to view the text.

which I tend to agree with. So maybe rather than consistently less dim, we want consistently more dim here. Not sure.

Probably requires further ux/design feedback. (@peppy? @arflyte?)

[peppy]

I don't really get this either. The goal was to dim 20% on top of the song select dim, but this seems to be undoing that? It doesn't feel like the correct solution, which would be that the editor should also get 20% darker when entering the loading screen no?

[64ArthurAraujo]

I don't really get this either. The goal was to dim 20% on top of the song select dim, but this seems to be undoing that?

It is undoing that because when disabling background blur in song select, song select makes the background darker so the UI doesn't look bad or something, when going from SongSelect -> PlayerLoader that dim is carried over to PlayerLoader making it darker as in the first example.

which would be that the editor should also get 20% darker when entering the loading screen no?

I think player loader's background should be "independent" from anything else so changes are consistent across every instance of PlayerLoader in the game, avoiding issues like this in the future.

So maybe rather than consistently less dim, we want consistently more dim here. Not sure.

I agree as well, more dim across every PlayerLoader may be better.