Add osu!taiko Constant Speed mod
#27341
Merged
+36
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bdach
reviewed
Feb 23, 2024
|
after more tinkering i resolved all the potential issues with this implementation (variable BPM maps and compatibility with mods that change scroll speed), should be ready for a 2nd pass/merge i reckon. |
bdach
reviewed
Feb 26, 2024
bdach
previously approved these changes
Mar 7, 2024
peppy
reviewed
Mar 8, 2024
|
small bump on this in case it slipped through the cracks, considering it seems like it's in a ready state now 👀 |
peppy
approved these changes
May 23, 2024
|
What is going to happen to this PR at this point then? If we're not making calls on multiplier ourselves (which I agree with, I have absolutely no clue if it's right or not) then do we just merge? summon the pp committee or something? |
smoogipoo
approved these changes
May 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #17927
no-longer-relevant blurb about previous implementation
initially tried implementing it through changing the(DrawableTaikoRuleset)drawableRuleset'sScrollVisualisationMethodtoConstantsimilar to osu!mania's Constant Speed mod, but that caused me 2 distinct issues:overall scroll speed was extremely lowDifficulty Adjust's scroll speed setting does not work with this mod (EZ/HR may also be affected but I didn't test)so, I've implemented this in a more straightforward manner (which follows the original proposal's intention) by simply setting every effect point's scroll speed (every inherited point's SV value in osu!stable terms) to1, which achieves the desired effect of the mod (neutralizing all SV changes relative to the map's base SV) + makes it compatible with other scroll speed changes made by mods like DA/HR/EZ.I've figured out how to implement this correctly using
ScrollVisualisationMethod, the method above doesn't account for maps with multiple BPM changes which results in those having "broken" scroll speed changes which negatively impacts gameplay. however, I still couldn't figure out how to allow for HR/EZ to change the base scroll speed whenScrollVisualisationMethodis set toConstant, so I'll be excluding them from working with this mod unless someone figures out how to make this work, as i believe this is currently a fair compromise to have correct implementation + clean gameplay in variable BPM maps.mod should be working fine with other mods that change scroll speed (EZ/HR/DA) and should have no issues with variable BPM maps now.
this also makes constant scroll speed look much more accurate in the editor.