Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PlayerLoader(Loading screen) is not dimmed in editor test mode #25515

Open
ilsubyeega opened this issue Nov 20, 2023 · 7 comments · May be fixed by #27746
Open

PlayerLoader(Loading screen) is not dimmed in editor test mode #25515

ilsubyeega opened this issue Nov 20, 2023 · 7 comments · May be fixed by #27746

Comments

@ilsubyeega
Copy link
Contributor

Type

Cosmetic

Bug description

Looks like #4893 before.
I don't think this is valid behavior, some backgrounds are too bright to view the text.
This non-dimmed bright thing happens at testing on editor mode, but backgrounds are dimmed on solo playing mode.

Screenshots or videos

(Ignore the lags, it's on low end laptop)

2023-11-20.205717.osu.mp4

image
image

Version

2023.1114.1-lazer

Logs

runtime.log
performance.log
network.log

@64ArthurAraujo
Copy link
Contributor

Was this indirectly fixed? i tried to reproduce and they look the same for me, the only difference is that they are equally bright now.

Player

player

Editor Player

editor

@ilsubyeega
Copy link
Contributor Author

@64ArthurAraujo 64ArthurAraujoWas this indirectly fixed? i tried to reproduce and they look the same for me, the only difference is that they are equally bright now.

At 2024.312.1-lazer using gnome linux dimming does not match from my side
image

And just for more information, gameplay from multiplayer also affect this though.

@64ArthurAraujo
Copy link
Contributor

@64ArthurAraujo 64ArthurAraujoWas this indirectly fixed? i tried to reproduce and they look the same for me, the only difference is that they are equally bright now.

At 2024.312.1-lazer using gnome linux dimming does not match from my side
image

And just for more information, gameplay from multiplayer also affect this though.

Weird i am using gnome as well but this screenshot is from the master branch i will check on the release as well later

@ilsubyeega
Copy link
Contributor Author

I've checked out the master branch and yeah it's consistent, but it's too bright.
image

@64ArthurAraujo
Copy link
Contributor

I cant reproduce it on release either (the outlined one is the editor), since it happened on your release only maybe its something with the configuration on your game (?)

capture

@ilsubyeega
Copy link
Contributor Author

ilsubyeega commented Mar 28, 2024

I've reset the whole setting and tested then, seems "song select/background blur" option affects this, when enabled it makes it more bright background.

asa.mp4

and yeah, this also reproducible on latest commit

@64ArthurAraujo
Copy link
Contributor

I've reset the whole setting and tested then, seems "song select/background blur" option affects this, when enabled it makes it more bright background.
asa.mp4

and yeah, this also reproducible on latest commit

I found out what happened and created a fix, will be a PR soon, what is happening is when you disable song select blur the game dims the background by 60%, when you enter the PlayerLoader screen that dim from song select is maintained and the PlayerLoader applies its own dim (20%) making the background appear even darker, so the correct one is actually the bright one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants