Add command line argument to allow a no-fork mode #160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Move arg parsing on top of main function - Add support for --no-daemon argument - Fork the process only if --no-daemon was not passed (so forking is still the default)
|
I've run into the same issue on other cosmic applications. I was thinking about making PRs for pretty much the same thing on some of the other cosmic applications as a compile time feature flag |
ChocolateLoverRaj
approved these changes
May 30, 2024
jackpot51
approved these changes
May 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a quick edit I had to make in order to debug a slight issue I had on my system, and I thought could be useful to other people as well.
I did not add any fancy command line argument parser such as
clap, just moved the command line argument parsing on top of themainfunction and allowed it to parse a--no-daemonargument to avoid process forking.Forking is still the default behaviour.