fix time applet #429
Closed
fix time applet #429
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maciekk64
reviewed
May 12, 2024
maciekk64
reviewed
May 12, 2024
|
I think the code is good enough for now. The only issue i can think of is that hours will always use two digits. I wonder how Gnome handle settings like military time, and layout condition, like displaying month before day. I don't think Datetime in fluent will cover all the need for this applet. |
mmstick
requested changes
May 15, 2024
| i18n-embed-fl.workspace = true | ||
| i18n-embed.workspace = true | ||
| libcosmic.workspace = true | ||
| libcosmic = {workspace = true, features = ["smol"]} |
There was a problem hiding this comment.
The binary already builds with tokio, so it should use that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR add localization support to the time applet.
I finally used the "unstable-locales" feature of
chrono, as it was already a dep, and it don't depend on system librairies.I reproduced the exact same layout of Gnome for the french language.
day_before_monthshould not be exposed to users, but deduced from the env or maybemilitary_time. It might be a good idea to look how gnome do this.show_secondsfeature was also added 馃帀