DRAFT: cosmic-applet-network: WPA2 Enterprise / 802.1x support #232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryanabx
force-pushed
the
features/network/wpa2
branch
from
11edcc3
to
67333a1
Compare
|
Unfortunately I can't continue the PR until #236 is resolved. |
... and UI work
ryanabx
force-pushed
the
features/network/wpa2
branch
from
67333a1
to
e1ff80c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will add support for networks that require both an identity and password to connect to the network.
Fixes: #225
Some questions I am thinking about while working on this:
Should the
NetworkManagerRequest::Passwordbe modified to include anidentityargument that will only optionally be used? Or should I make a separateNetworkManagerRequest::IdentityPasswordrequest that has the 3 arguments (SSID, identity, password).I'm still working out how to use NetworkManager to detect when a network is using a scheme that requires an identity. I'll be doing more research into the NetworkManager interface.
Side note: This is my first time using Rust! 馃