Add support for 2D meshes in 3D #321
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Pranav Jain <pranavj@usc.edu>
zfergus
commented
Mar 6, 2024
| @@ -211,8 +211,7 @@ namespace polyfem | |||
| std::shared_ptr<ImplicitTimeIntegrator> time_integrator; | |||
| if (is_scalar_or_mixed) | |||
| { | |||
| time_integrator = std::make_shared<BDF>(); | |||
| time_integrator->set_parameters(args["time"]); | |||
| time_integrator = std::make_shared<BDF>(1); // TODO: use the parameter from the json file | |||
There was a problem hiding this comment.
Fix this or create an Issue
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #321 +/- ##
==========================================
- Coverage 63.17% 63.12% -0.05%
==========================================
Files 267 267
Lines 33536 33584 +48
==========================================
+ Hits 21185 21199 +14
- Misses 12351 12385 +34
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for shell elements (2D mesh in 3D space).
Here is an example of the Laplace-Beltrami operator:
Heat equation:
Reopen #214