Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix empty string checks in umfmessage.js #217

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

fix empty string checks in umfmessage.js #217

wants to merge 3 commits into from

Conversation

JustusFluegel
Copy link

@JustusFluegel JustusFluegel commented Nov 22, 2020 •
edited

Empty checks in umfmessage.js are just if(var) but it should be if(var != null) for nullish strings like ''

@JustusFluegel JustusFluegel changed the title fix validate function WIP: fix empty string checks in umfmessage.js Nov 22, 2020
@JustusFluegel JustusFluegel changed the title WIP: fix empty string checks in umfmessage.js fix empty string checks in umfmessage.js Nov 22, 2020
cjus
cjus reviewed Nov 23, 2020
View reviewed changes
Copy link
Contributor

@cjus cjus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this. I left some comments and a question regarding the ES2020's Nullish Coalescing Operator.

lib/umfmessage.js Outdated Show resolved Hide resolved
lib/umfmessage.js Outdated Show resolved Hide resolved
lib/umfmessage.js Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjus cjus Awaiting requested review from cjus

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@JustusFluegel @cjus