Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dropdown #2854

Merged
merged 3 commits into from
May 14, 2024
Merged

Fix dropdown #2854

merged 3 commits into from
May 14, 2024

Conversation

T4rk1n
Copy link
Contributor

@T4rk1n T4rk1n commented May 9, 2024

Fix dropdown with a value of "" resetting to None. Fix #2850

@emilykl
Copy link
Contributor

emilykl commented May 9, 2024

Wow, great detective work @T4rk1n .

Could you explain the issue and the fix in a bit more detail?

@T4rk1n
Copy link
Contributor Author

T4rk1n commented May 10, 2024

We discovered the value was getting reset to null and triggering callbacks that ends up breaking the docs in some odd testing case. The empty string should have been considered the same as null and not trigger the reset.

Copy link
Contributor

@emilykl emilykl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@T4rk1n T4rk1n merged commit 746d648 into dev May 14, 2024
3 checks passed
@T4rk1n T4rk1n deleted the fix/drop-search branch May 14, 2024 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dropdown changes in Dash 2.17 causing page loading issues in Dash docs
2 participants