Add library loading capacity to _allow_dynamic_callbacks.
#2789
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
syl-oh
reviewed
May 1, 2024
Comment on lines
+13
to
+18
| prom = new Promise<void>((resolve, reject) => { | ||
| element.onload = () => { | ||
| resolve(); | ||
| }; | ||
| element.onerror = error => reject(error); | ||
| }); |
There was a problem hiding this comment.
since the way you are creating the promise is the same for both, you could extract that into a function to avoid duplication. Like with a makePromise(element) which would do that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
_allow_dynamic_callbacks=True, callback can now import a component library and automatically loaded on the callback returns. Same restrictions as adding callbacks during callbacks, only guaranteed to work for a single user, meant to be used for development purposes.