Fix Laplacian filter wrong sign scikit-image#7357

pitkajuh · Apr 13, 2024 · a384418 · a384418
1 parent 7ae4fd8
commit a384418
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 7 deletions.
diff --git a/skimage/filters/tests/test_edges.py b/skimage/filters/tests/test_edges.py
@@ -362,11 +362,11 @@ def test_laplace_zeros():
         [
             [0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0],
             [0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0],
-            [0.0, 0.0, 0.0, -1.0, -1.0, -1.0, 0.0, 0.0, 0.0],
-            [0.0, 0.0, -1.0, 2.0, 1.0, 2.0, -1.0, 0.0, 0.0],
-            [0.0, 0.0, -1.0, 1.0, 0.0, 1.0, -1.0, 0.0, 0.0],
-            [0.0, 0.0, -1.0, 2.0, 1.0, 2.0, -1.0, 0.0, 0.0],
-            [0.0, 0.0, 0.0, -1.0, -1.0, -1.0, 0.0, 0.0, 0.0],
+            [0.0, 0.0, 0.0, 1.0, 1.0, 1.0, 0.0, 0.0, 0.0],
+            [0.0, 0.0, 1.0, -2.0, -1.0, -2.0, 1.0, 0.0, 0.0],
+            [0.0, 0.0, 1.0, -1.0, 0.0, -1.0, 1.0, 0.0, 0.0],
+            [0.0, 0.0, 1.0, -2.0, -1.0, -2.0, 1.0, 0.0, 0.0],
+            [0.0, 0.0, 0.0, 1.0, 1.0, 1.0, 0.0, 0.0, 0.0],
             [0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0],
             [0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0],
         ]

diff --git a/skimage/restoration/uft.py b/skimage/restoration/uft.py
@@ -444,8 +444,8 @@ def laplacian(ndim, shape, is_real=True):
         idx = tuple(
             [slice(1, 2)] * dim + [slice(None)] + [slice(1, 2)] * (ndim - dim - 1)
         )
-        impr[idx] = np.array([-1.0, 0.0, -1.0]).reshape(
+        impr[idx] = np.array([1.0, 0.0, 1.0]).reshape(
             [-1 if i == dim else 1 for i in range(ndim)]
         )
-    impr[(slice(1, 2),) * ndim] = 2.0 * ndim
+    impr[(slice(1, 2),) * ndim] = -2.0 * ndim
     return ir2tf(impr, shape, is_real=is_real), impr