Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a given calving rate from file or option #517

Open
wants to merge 28 commits into
base: dev
Choose a base branch
from

Conversation

talbrecht
Copy link
Member

This code addition is supposed to read a calving rate from file or set it per option to constant. This is code that may be used in CalvingMIP.

However it does not update the calving rate yet for option -calving given_calving -calving_rate 20000.0. I used the examples/mismip/mismip2d as example. What did I miss?

Checklist

  • update documentation
  • update CHANGES.rst
  • add regression tests

@ckhroulev ckhroulev changed the base branch from main to dev October 26, 2022 19:20
Copy link
Member

@ckhroulev ckhroulev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me now!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants