Police patrol improvement #5809
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If we aim to do one last "bug fix release" then this would be merged after that. So far, there's just been one bug fix merged since the 3.14 release. |
Web-eWorks
requested changes
Apr 19, 2024
robothauler
force-pushed
the
police_patrol
branch
from
e943552
to
9d01b7c
Compare
Web-eWorks
reviewed
Apr 21, 2024
| if ship:DistanceTo(patrol[i]) <= 4000000 then | ||
| Comms.ImportantMessage(string.interp(l_ui_core.X_CANNOT_BE_TOLERATED_HERE, { crime = l_ui_core.PIRACY }, patrol[i].label)) | ||
| if ship:DistanceTo(patrol[i]) <= lawEnforcedRange then | ||
| Comms.ImportantMessage(string.interp(l_ui_core.X_CANNOT_BE_TOLERATED_HERE, { crime = l_ui_core.UNLAWFUL_WEAPONS_DISCHARGE }, patrol[i].label)) |
There was a problem hiding this comment.
Note for future reference that string.interp(l.SOME_STRING, { crime = ... }) is also available via a custom operator as l.SOME_STRING % { crime = ... }. You don't need to amend this PR to prefer the use of either one however.
Web-eWorks
approved these changes
Apr 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not entirely perfect. But an improvement.
Fixes #5603
It does not solve the police apathy problem described in #5202