Refactor and rework random system generator

[Mc-Pain]

Current implementation allows up to four stars in the system with only layout of "two binary systems orbiting each other"

• Clean up the code
• Work out on star layouts
• Remove upper limit of stars being generated (separate PR)

[fluffyfreak]

This is good work! Glad to see someone showing this code some care and attention

[Mc-Pain]

Looks messy

[Mc-Pain]

[Mc-Pain]

removed WIP: sign, third task would be completed through separate PR

[fluffyfreak]

I can't spot any coding issues, although the ULGY HACK part could be nice to cleanup

[Mc-Pain]

I can't spot any coding issues, although the ULGY HACK part could be nice to cleanup

I don't know how to make it pretty, it generates an i-th uppercase letter

[fluffyfreak]

Does this change the universe generation at all?

[Mc-Pain]

Does this change the universe generation at all?

In what terms?

[fluffyfreak]

In what terms?

Naming of systems, numbers of stars/planets/etc, anything like that or is it purely a code reorganisation?

[Mc-Pain]

In what terms?

Naming of systems, numbers of stars/planets/etc, anything like that or is it purely a code reorganisation?

Number of planets could vary. Number of stars for each system is done in sector generator.

Only change here is how star types are generated

[fluffyfreak]

@Mc-Pain would you mind if I pushed a small change to your PR to cleanup the UGLY HACK ?

[Mc-Pain]

@Mc-Pain would you mind if I pushed a small change to your PR to cleanup the UGLY HACK ?

+, go ahead

[impaktor]

@fluffyfreak Wait with asking until after you've done it. (looks like mcpain gave thumbs up on your post, but you're not notified by that)

EDIT: looks like me and mcpain posted at the same time

[fluffyfreak]

@Web-eWorks I'm happy with this as-is but as I've (tried to) contribute to the code I'm not going to judge whether it should be merged, also with the changes it may have changed the generated universe which requires a savegame bump?

[impaktor]

I'd recommend holding off on merge until after 3.14, when we intend to release a bug-fix zuper-ztable Tauoneer (tau = 2 x pi, Tauoneer = Pi-Pioneer - yes, I'll keep proposing that). Players of the 3.14 release are Tauonauts.

Only bug-fixes and PRs that are unlikely to introduce bugs before 3.14, and no save-bumps, according to the Board of Directors of Pioneer.
Tauoneer - dammit!.

[Mc-Pain]

I'd recommend holding off on merge until after 3.14, when we intend to release a bug-fix zuper-ztable Tauoneer (tau = 2 x pi, Tauoneer = Pi-Pioneer - yes, I'll keep proposing that). Players of the 3.14 release are Tauonauts.

Only bug-fixes and PRs that are unlikely to introduce bugs before 3.14, and no save-bumps, according to the Board of Directors of Pioneer. Tauoneer - dammit!.

[Web-eWorks]

Apologies on the delay officially responding here. I'll be reviewing this PR soon after the 3.14 hotfix release, as I'd prefer not to introduce a savegame bump in the upcoming release if it's not absolutely necessary.

[impaktor]

<impaktor> sturnclaw: Seems like you're slightly more active again. If so,
           looks like #5748 is ready for review.  [12:18]
<cmdr-jameson> pull request #5748: Refactor and rework random system generator
               https://github.com/pioneerspacesim/pioneer/pull/5748
<mcpain> always has been  [12:59]
<impaktor> meme  [13:00]
<mcpain> da  [13:01]