Music tracks will be played continuously while game speed is set to paused #5644
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Maybe fade out the music upon pause, and fade in when unpaused? |
|
@nozmajner I meant that this happenes when you set your game speed to pause, I can change description to clarify more. But I suppose this can be added, maybe in the other PR? |
|
Oh sorry, I thought it is a report, not a PR |
Max5377
changed the title
|
It's not obvious to me that game music should keep playing in paused mode. (What if you paused because your boss is walking towards your computer, when you're sneakily playing pioneer waiting for your work code to compile?) |
|
@impaktor Some thoughts about it:
|
Max5377
force-pushed
the
music-will-continue-to-play-while-paused
branch
from
81c09fd
to
eded274
Compare
MusicPlayer will now continue to play tracks while game is paused, instead of playing one track and get silenced until game is unpaused.
Max5377
force-pushed
the
music-will-continue-to-play-while-paused
branch
from
eded274
to
2e7ba26
Compare
Merged
|
Lest we forget this PR; @WKFO do you have any objections to this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MusicPlayer will now continue to play tracks while game is paused, instead of playing one track and get silenced until unpaused.
Edit: rebase.
Edit2: rebase.