Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expression: Report error when empty pattern in regexp related function #53230

Merged
merged 2 commits into from May 14, 2024

Conversation

yibin87
Copy link
Contributor

@yibin87 yibin87 commented May 13, 2024

What problem does this PR solve?

Issue Number: close #53221

Problem Summary:
Tidb report error when these functions are executed in row by row mode. But failed to check it in vector mode.

What changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

Signed-off-by: yibin <huyibin@pingcap.com>
@ti-chi-bot ti-chi-bot bot added release-note-none size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 13, 2024
Copy link

tiprow bot commented May 13, 2024

Hi @yibin87. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@yibin87
Copy link
Contributor Author

yibin87 commented May 13, 2024

/cc @xzhangxian1008 @lcwangchao

@yibin87
Copy link
Contributor Author

yibin87 commented May 13, 2024

/cc @windtalker

@ti-chi-bot ti-chi-bot bot requested a review from windtalker May 13, 2024 09:03
@yibin87
Copy link
Contributor Author

yibin87 commented May 13, 2024

/hold

@ti-chi-bot ti-chi-bot bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 13, 2024
@yibin87
Copy link
Contributor Author

yibin87 commented May 13, 2024

hold to wait for copr-test pr tikv/copr-test#183 merged

Copy link

codecov bot commented May 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.6630%. Comparing base (41ce0a5) to head (503bd82).
Report is 5 commits behind head on master.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #53230        +/-   ##
================================================
+ Coverage   72.4118%   74.6630%   +2.2512%     
================================================
  Files          1493       1493                
  Lines        429344     430822      +1478     
================================================
+ Hits         310896     321665     +10769     
+ Misses        99146      89288      -9858     
- Partials      19302      19869       +567     
Flag Coverage Δ
integration 49.2118% <20.0000%> (?)
unit 71.2510% <100.0000%> (-0.0469%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9957% <ø> (ø)
parser ∅ <ø> (∅)
br 50.4316% <ø> (+8.9914%) ⬆️

Signed-off-by: yibin <huyibin@pingcap.com>
@yibin87 yibin87 requested a review from windtalker May 14, 2024 01:28
Copy link
Contributor

@xzhangxian1008 xzhangxian1008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yibin87
Copy link
Contributor Author

yibin87 commented May 14, 2024

/unhold

@ti-chi-bot ti-chi-bot bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 14, 2024
Copy link
Contributor

@windtalker windtalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

ti-chi-bot bot commented May 14, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: windtalker, xzhangxian1008

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

ti-chi-bot bot commented May 14, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-05-14 01:49:28.08989497 +0000 UTC m=+1531521.847030538: ☑️ agreed by xzhangxian1008.
  • 2024-05-14 02:15:56.793617287 +0000 UTC m=+1533110.550752856: ☑️ agreed by windtalker.

Copy link

tiprow bot commented May 14, 2024

@yibin87: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
fast_test_tiprow 503bd82 link true /test fast_test_tiprow

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@ti-chi-bot ti-chi-bot bot merged commit 4b91fee into pingcap:master May 14, 2024
22 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Regexp should report error when pattern parameter is empty string
3 participants