Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

planner: Use dual plan when comparing with null values | tidb-test=pr/2328 #53206

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

King-Dylan
Copy link
Contributor

@King-Dylan King-Dylan commented May 12, 2024

What problem does this PR solve?

Issue Number: close #51446

Problem Summary:
When comparing with null values in SQL, the result set will always be empty, so we can replace the execution plan with 'tabledual'.

What changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

Copy link

ti-chi-bot bot commented May 12, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign ailinkid for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

ti-chi-bot bot commented May 12, 2024

Hi @King-Dylan. Thanks for your PR.

I'm waiting for a pingcap member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot bot added needs-ok-to-test size/L Denotes a PR that changes 100-499 lines, ignoring generated files. sig/planner SIG: Planner labels May 12, 2024
Copy link

tiprow bot commented May 12, 2024

Hi @King-Dylan. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@hawkingrei
Copy link
Member

/ok-to-test

Copy link

codecov bot commented May 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.6234%. Comparing base (97d4705) to head (aba1089).
Report is 30 commits behind head on master.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #53206        +/-   ##
================================================
+ Coverage   72.4761%   74.6234%   +2.1473%     
================================================
  Files          1491       1493         +2     
  Lines        429017     435355      +6338     
================================================
+ Hits         310935     324877     +13942     
+ Misses        98866      90515      -8351     
- Partials      19216      19963       +747     
Flag Coverage Δ
integration 49.2083% <100.0000%> (?)
unit 71.2366% <85.0000%> (-0.1317%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9957% <ø> (ø)
parser ∅ <ø> (∅)
br 50.2074% <ø> (+8.7638%) ⬆️

@King-Dylan
Copy link
Contributor Author

/retest

@King-Dylan
Copy link
Contributor Author

/retest

@King-Dylan King-Dylan changed the title planner: Use dual plan when comparing with null values planner: Use dual plan when comparing with null values | tidb-test=pr/2328 May 13, 2024
@King-Dylan
Copy link
Contributor Author

/test mysql-test

Copy link

tiprow bot commented May 13, 2024

@King-Dylan: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test fast_test_tiprow
  • /test tidb_parser_test

Use /test all to run all jobs.

In response to this:

/test mysql-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link

ti-chi-bot bot commented May 13, 2024

@King-Dylan: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
idc-jenkins-ci-tidb/mysql-test aba1089 link true /test mysql-test

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ok-to-test release-note-none sig/planner SIG: Planner size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Do not need to push down ColumnRef <compare_operator> null which is always false
2 participants