Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expression: fix the collation of functions with json arguments (#53126) #53203

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #53126

What problem does this PR solve?

Issue Number: close #52833

Problem Summary:

MySQL will use binary collation when the max_length of some arguments' types are too long. It'll mostly happen on JSON types.

What changed and how does it work?

As TiDB doesn't have a max_length attribute for each type and "datum", I specially handled the situation for JSON. Some function will return binary collation when some of the arguments are JSON type.

In MySQL, the state of BINARY flag, BLOB type and binary collation is really a chaos. For this example, you'll find that sometimes the collation(...) returns utf8mb4_bin while the returned type info (shown through --column-type-info) tells you the collation is utf8mb4_0900_ai_ci. I'm not sure whether it's a bug for MySQL or not...

So, I want to fix the behavior with minimum modification: only change the collation to binary collation and don't touch the charset.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

Fix the issue that the collation of the result of some functions are not compatible with MySQL when the arguments contain JSON.

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot added compatibility-breaker Violation of forwards/backwards compatibility in a design-time piece. release-note size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/cherry-pick-for-release-7.5 labels May 11, 2024
Copy link

ti-chi-bot bot commented May 11, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign zanmato1984 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Signed-off-by: Yang Keao <yangkeao@chunibyo.icu>
Copy link

codecov bot commented May 22, 2024

Codecov Report

Attention: Patch coverage is 92.30769% with 3 lines in your changes are missing coverage. Please review.

Please upload report for BASE (release-7.5@b004a3f). Learn more about missing BASE report.

Additional details and impacted files
@@               Coverage Diff                @@
##             release-7.5     #53203   +/-   ##
================================================
  Coverage               ?   71.9982%           
================================================
  Files                  ?       1411           
  Lines                  ?     410074           
  Branches               ?          0           
================================================
  Hits                   ?     295246           
  Misses                 ?      94961           
  Partials               ?      19867           
Flag Coverage Δ
unit 71.9982% <92.3076%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9913% <0.0000%> (?)
parser ∅ <0.0000%> (?)
br 53.4243% <0.0000%> (?)

@YangKeao
Copy link
Member

Close, because it will break compatibility.

@YangKeao YangKeao closed this May 23, 2024
@ti-chi-bot ti-chi-bot removed the cherry-pick-approved Cherry pick PR approved by release team. label May 23, 2024
Copy link

ti-chi-bot bot commented May 23, 2024

This cherry pick PR is for a release branch and has not yet been approved by triage owners.
Adding the do-not-merge/cherry-pick-not-approved label.

To merge this cherry pick:

  1. It must be approved by the approvers firstly.
  2. AFTER it has been approved by approvers, please wait for the cherry-pick merging approval from triage owners.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
compatibility-breaker Violation of forwards/backwards compatibility in a design-time piece. do-not-merge/cherry-pick-not-approved release-note size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/cherry-pick-for-release-7.5
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants