Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only enable symfony error handler in debug mode #513

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jkrzefski
Copy link
Contributor

I don't know why the Symfony error handler is always enabled. Maybe there is a deeper meaning behind it that I don't see. But if not, I propose to only use Debug when debugging is requested (via config or command option).

@acasademont
Copy link
Contributor

Not so sure about this one, if the server crashes (during the bridge bootstrap, for example) there might be very little info about what happened. Did you run some tests on it?

@jkrzefski
Copy link
Contributor Author

No, I did not run any tests on my end. I only looked through the code, spotted this and thought it looked wrong. The travis build seems fine, though.

I am totally ok with leaving it the way it was. I would merely like a short explanation on why the error handler is enabled in production. Maybe a comment in the code would be nice, so others don't get confused like I was.

@andig
Copy link
Contributor

andig commented Aug 12, 2020

Enable during startup and disable after first client answer sent?

@andig
Copy link
Contributor

andig commented Jan 8, 2022

I am totally ok with leaving it the way it was. I would merely like a short explanation on why the error handler is enabled in production. Maybe a comment in the code would be nice, so others don't get confused like I was.

Could you propose what you'd expect?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants