-
Notifications
You must be signed in to change notification settings - Fork 368
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add TCP Context in the configuration #478
base: master
Are you sure you want to change the base?
Conversation
Hum, i'm not sure I am responsible for the failed tests. It seems Symfony 5 enforce execute returns only integers, and not null on commands. |
There are some other issues like https://travis-ci.org/php-pm/php-pm/jobs/617713470#L365, please take a look. I don't see any related to Symfony. |
Yeah, I forgot to manage PHP 7.1. I added a condition to polyfill (sort of) when But I keep having some bugs with return value of execute's command :
|
That would need a separate PR, didn't catch that when Symfony 5 was allowed. See #479. |
I updated my PR with your changes 😉 |
Looking good to me. I imagine a more typical scenario would be to deploy ppm behind an SSL-terminating reverse proxy (Traefik etc). ping @marcj for approval |
Any news on this ? @marcj ? |
Agreed. It would make sense to allow configuration of all aspects of the server configuration. |
@kdubuc would you be able to work on those changes? |
Yes, I just need some free times but I will work on this PR ;) |
ping @kdubuc ;) |
Add the possibility to provide the TCP context in the start process of ProcessManager, and gives the opportunity to build Secure Socket. Related #462
Usage : This PR add
--tcp-context
option which accept an JSON array encoded.Example :
php bin/ppm start --tcp-context '{"tls":{"local_cert": "test.pem"}}'
This is the first shot.
What do you think ?
Also, I have some difficulty to make the ConfigTrait testable, if you have some ideas, I will take them.