Implement connection.update-secret to support rabbit_auth_backend_oauth2 #1160
Conversation
kratkyzobak
force-pushed
the
oauth2-update-secret
branch
from
4673bb5
to
b8df98d
Compare
kratkyzobak
force-pushed
the
oauth2-update-secret
branch
3 times, most recently
from
1fc6787
to
950989c
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #1160 +/- ##
============================================
+ Coverage 74.10% 74.24% +0.13%
- Complexity 1042 1051 +9
============================================
Files 39 39
Lines 3136 3168 +32
============================================
+ Hits 2324 2352 +28
- Misses 812 816 +4 ☔ View full report in Codecov by Sentry. |
kratkyzobak
force-pushed
the
oauth2-update-secret
branch
from
950989c
to
6e1376a
Compare
| @@ -36,6 +36,7 @@ | |||
| }, | |||
| "require-dev": { | |||
| "ext-curl": "*", | |||
| "ext-openssl": "*", | |||
There was a problem hiding this comment.
Library itself does not need this extension, only tests.
| */ | ||
| public static function connectionUpdateSecretOk(AMQPReader $reader) | ||
| { | ||
| $response = array(); |
There was a problem hiding this comment.
Method is generated by your code.
| } | ||
|
|
||
| // for potential cloning | ||
| $this->replace_password_in_construct_params($password); |
There was a problem hiding this comment.
Constructor params are deprecated and will be dropped in version 4.0
There was a problem hiding this comment.
When will version 4.0 released? Will version 4.0 handle OAuth?
| /** | ||
| * @param string $password | ||
| */ | ||
| protected function replace_password_in_construct_params($password) |
| define('JWT_TOKEN_1', getenv('TEST_RABBITMQ_JWT_TOKEN_1') ? getenv('TEST_RABBITMQ_JWT_TOKEN_1') : generateJwtToken(7200)); | ||
| define('JWT_TOKEN_2', getenv('TEST_RABBITMQ_JWT_TOKEN_2') ? getenv('TEST_RABBITMQ_JWT_TOKEN_2') : generateJwtToken(7205)); | ||
|
|
||
| function generateJwtToken($expire = 7200) |
There was a problem hiding this comment.
this should be part of test, abstract test class or something "on demand" but not defined as global constats, whats the point?
| * Should be used for RabbitMQ's OAuth2 authentication backend to update current token. | ||
| * @param string $password | ||
| */ | ||
| public function updatePassword($password): void |
|
Next minor version is only for bugfixes and deprecations. Afterwards we will refactor many things related to connections. So we can't accept this for 3.x series. At best for 4.0. |
Implementation of "simple" part of #1159
This PR implements method
connection.update-secretand exposes it to library consumers as*Connection::updatePassword($password);. Naming were chosen this way as it is just updating previously set$passwordin constructor. Method also updates internal password properties of Connection classes. This enables to reconnect and/or support lazy connections.