-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove the drush
config file.
#68
base: main
Are you sure you want to change the base?
Remove the drush
config file.
#68
Conversation
Actually the environment variable is supposed to override That being said, I'm not sure we will really need the So what might be better here is to adjust the |
Oh, yes. Sometimes I forget there is a world outside ddev. I will try to find a possible solution to make changes just for ddev. |
I suggest adding |
I would probably not merge that, precisely because it will affect things outside the container. I would maybe see if there's a way DDEV can be configured to exclude the |
I think this is probably a drush issue and not a DDEV issue. Best to solve in drush. Discord discussion: https://discord.com/channels/664580571770388500/1239629371279671316 You might be able to bind-mount an empty directory on top of the .drush directory using something like https://stackoverflow.com/questions/57426306/ddev-mount-additional-folders-for-shared-composer-packages/57432155#57432155 |
Thank you @rfay for your inputs. That's what I was thinking when I looked at it: https://stackoverflow.com/questions/29181032/add-a-volume-to-docker-but-exclude-a-sub-folder Okay, I will brainstorm this a bit more. |
As mentioned by @phenaproxima above on #68 (comment)
I found the PR: drush-ops/drush#5961 I'm not opening an issue on Drush as it has been fixed in the beta version of Drush. Although I was not able to validate this on my end. That being said, I feel we can either live with this issue for now or follow what @rfay has suggested
|
I feel we should remove the drush configuration file, as it is overwriting the
DRUSH_OPTIONS_URI
setting when runningddev drush uli
.Which outputs:
http://localhost/user/reset/1/1715615952/V4pMvp5c1aWQEmBgFFGbdZHeQno1xkPWy_nU7n1FAzM/login
Removing the Drush configuration file will ensure that the
DRUSH_OPTIONS_URI
value is used when runningdrush uli
.After removing:
https://starshot.ddev.site/user/reset/1/1715616070/dPXXBM1fnUh6Nr17Snep7G1SH1hgZViuWiEyPg3El0E/login