Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PR to fix null pointer exception. #6816

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

jacklehamster
Copy link

@jacklehamster jacklehamster commented May 14, 2024

Please do not update the README or Change Log, we will do this when we merge your PR.

This PR (delete as applicable)

  • Fixes a bug

Describe the changes below:

Encountered the following null pointer exception:

Uncaught TypeError: Cannot set properties of undefined (setting 'controller')
    at FX.add (index.js:20011:39)
    at FX.addGlow (index.js:20023:27)
    at index.js:5204:132

This occurred only on Windows (VM on UTM, not sure if that made a difference) when trying to use special FX. This didn't happen on Mac.

The bug happened on all specials effects applied, on text or images (postFX.addGlow).
See code: https://github.com/jacklehamster/phaser-game/blob/main/src/hischool/game.ts#L2372

Uncaught TypeError: Cannot set properties of undefined (setting 'controller')

occurring on Windows when adding effects.
This reverts commit f87cffd.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant