-
Notifications
You must be signed in to change notification settings - Fork 693
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed initializing ContinuousFactor to a GaussianDistribution #991
base: dev
Are you sure you want to change the base?
Fixed initializing ContinuousFactor to a GaussianDistribution #991
Conversation
def test_class_init_gaussian(self): | ||
mean = np.array([1, -3, 4]) | ||
cov = np.array([[4, 2, -2], [2, 5, -5], [-2, -5, 8]]) | ||
phi1 = ContinuousFactor(['x1', 'x2'], 'gaussian', mean=mean, covariance=cov) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@JustinTervala This distribution is a 3 variable distribution. Please add one more variable. Tests should pass then.
@JustinTervala Please rebase your branch to latest dev. You can read about rebase here. Also, please squash the commits into a single commit. |
Codecov Report
@@ Coverage Diff @@
## dev #991 +/- ##
==========================================
+ Coverage 94.76% 94.79% +0.03%
==========================================
Files 116 116
Lines 11314 11322 +8
==========================================
+ Hits 10722 10733 +11
+ Misses 592 589 -3
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@JustinTervala Can you please make changes to docs. In Line 24 pdf can be of type function or a str not just function. Also, can you add an example on how to create GaussianDistribution using string.
* Fixed incorrect link to Monty Hall Example in docs * Fixed typeo in link
73e47bc
to
1819e5f
Compare
@JustinTervala Thanks for the PR. Could you please rebase your branch to the latest dev ? |
@ankurankan @JustinTervala I believe we should also add an example on how to create GaussianDistribution using string. |
Fixes
This fix allows a ContinuousFactor to be directly constructed to use a GaussianDistribution as identified in issue 990.
#990
The tests on my branch aren't passing, but the test written for this PR passes