-
Notifications
You must be signed in to change notification settings - Fork 693
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed spelling errors in docstrings #989
base: dev
Are you sure you want to change the base?
Conversation
Codecov Report
@@ Coverage Diff @@
## dev #989 +/- ##
==========================================
- Coverage 94.77% 94.76% -0.01%
==========================================
Files 116 116
Lines 11314 11314
==========================================
- Hits 10723 10722 -1
- Misses 591 592 +1
Continue to review full report at Codecov.
|
@@ -570,7 +570,7 @@ def _add_element(potential, var, potential_tag): | |||
For example: {'role': 'Utility', | |||
'Variables': ['D0', 'D1', 'C0', 'C1'], | |||
'type': 'Tree/ADD', | |||
'UtilityVaribale': 'U1'} | |||
'UtilityVariable': 'U1'} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ankurankan Is this done on purpose? Or in code at line 947 mistake has been repeated. I'm not able to understand.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I purposefully did not change that field name to avoid changing the API. If you would like, I can change it there too
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@JustinTervala @khalibartan I think that is a typo and should be fixed.
@JustinTervala Thanks for the PR. It would be great if you could sqaush all your commits in a single commit and rebase your branch on current dev. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good except for one more typo fix.
68ac4b1
to
5518bb4
Compare
5518bb4
to
be588a1
Compare
@JustinTervala Couple of tests are failing. Could you please check ? |
Fixes
This PR fixes multiple spelling errors as identified by PyCharm. It addresses Issue 988
#988