New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug fixes for ExactInference on continuous factors #941
base: dev
Are you sure you want to change the base?
Conversation
@linzhp The tests are failing, could you check please ? |
I tried Python 3.6, 3.5 and 2.7 on Windows, but I can't reproduce the test failure. I will try running it on Linux. Also, from the Travis' log, I saw this:
The Python version it used was wrong. So essentially, Travis only ran the test in Python 2.7 for three times. |
Yeah, it's not failing on windows. The appveyor builds on windows and it's passing.
No, the python versions are correct actually. The |
Codecov Report
@@ Coverage Diff @@
## dev #941 +/- ##
==========================================
+ Coverage 94.71% 94.76% +0.05%
==========================================
Files 114 114
Lines 11185 11201 +16
==========================================
+ Hits 10594 10615 +21
+ Misses 591 586 -5
Continue to review full report at Codecov.
|
All tests passed now. Please take another look, @ankurankan |
Variable Elimination for continuous variables was broken when there is only one query variable, as illustrated by the added unit test in this PR. This PR fixed it.
@ankurankan Please review.