Add the ability to use a pre-count column when computing the state-counts #884
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In case, the counts of the various states are already available in a column, this feature allows to use them to compute the state-counts. It therefore allows use of more compact dataframes.
|
@npfp I am not sure if adding a new parameter helps in any way. @khalibartan Opinion ? |
|
@ankurankan @npfp Even I'm not sure about any benefit of doing so. But I don't think pre-count would be available in most of the cases. |
|
Hi,
Thanks for your replies. Here are two answers to your remarks.
- The benefit is that if you want to apply pgmpy to a dataframe which is too big to be loaded in memory, you could use a MapReduce job to pre-count the states and then apply pgmpy to it.
- the default behaviour doesn't change and it is of course still compatible with dataframes which don't have the pre-count column.
Thanks,
N.
… Le 15 juin 2017 à 3:54 PM, Utkarsh ***@***.***> a écrit :
@ankurankan @npfp Even I'm not sure about any benefit of doing so. But I don't think pre-count would be available in most of the cases.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the case, the counts of the various states are already available in a
column of the dataframe, this feature allows to use them to compute the state-counts.
It therefore allows use of more compact dataframes.