Find(), ConstFind() dictionary methods, .gitignore #89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also DOS-to-Unixify BamReader.h endlines and remove an extra set of parens in bamtools.cpp
Also initiate README.md for this fork
…onary With my addition of BamReader::GetConstSamHeader(), the operator[] method for querying SamSequenceDictionary no longer worked as it couldn't handle a const this. Since it had a default not-found behavior of adding the query name, I think these Find() iterator-based methods, as parallels to the find() methods of map containers are better with read-only access. The End() iterator is returned if sequenceName is not found.
Conflicts: CMakeLists.txt src/api/BamReader.h
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For SamSequenceDictionary, adds a Find(), Find() const, and equivalent ConstFind() method to return iterators into the sequence dictionary.
Also adds a .gitignore, feel free to ignore that...